Fixed nil pointer when no Jaeger is suitable for sidecar injection #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please review, @rubenvp8510 ? |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
Fixed-nil-pointer-requireUpdates
branch
from
f5c30a2 to
00c2864
Compare
rubenvp8510
reviewed
Nov 21, 2019
pkg/autodetect/main.go
Outdated
| "deploymentName": dep.Name, | ||
| "deploymentNamespace": dep.Namespace, | ||
| }).Debug("no suitable jaeger for this instance, skipping injection") | ||
| return nil |
There was a problem hiding this comment.
I think this should be a continue not return, we need to process the rest of the deployments.
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling [email protected]